Skip to content

feat: added the ability to close the hint using the keyboard #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: added the ability to close the hint using the keyboard #1605

wants to merge 3 commits into from
+222 −4

Conversation

vladislavkeblysh
Copy link

@vladislavkeblysh vladislavkeblysh commented Feb 24, 2025 •
edited
Loading

Description

This PR provides a mechanism to close the tooltip using the keyboard. The escape key is recommended

Testing instructions

  1. Create new course
  2. Go to Progress page
  3. Place focus on tooltip content when the tooltip button is activated.
  4. Close tooltip with Escape key
  5. Ensure focus is trapped within the tooltip until it is close.
Screen.Recording.2025-05-02.at.13.28.19.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 24, 2025 •
edited
Loading

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (af432ea) to head (c315f6d).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1605      +/-   ##
==========================================
+ Coverage   90.18%   90.35%   +0.16%     
==========================================
  Files         339      343       +4     
  Lines        5810     5753      -57     
  Branches     1409     1382      -27     
==========================================
- Hits         5240     5198      -42     
+ Misses        552      538      -14     
+ Partials       18       17       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/grade-summary-tooltip branch from 914c375 to e42a23a Compare February 24, 2025 19:11
@itsjeyd itsjeyd added the product review PR requires product review before merging label Feb 27, 2025
@itsjeyd
Copy link

itsjeyd commented Feb 27, 2025

@vladislavkeblysh Thank you for this contribution!

Same note about product review here.

@vladislavkeblysh vladislavkeblysh self-assigned this Mar 4, 2025
@vladislavkeblysh vladislavkeblysh changed the title feat: [AsPu-651] added the ability to close the hint using the keyboard feat: added the ability to close the hint using the keyboard Mar 5, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/grade-summary-tooltip branch from e42a23a to c8c8168 Compare March 5, 2025 09:27
@itsjeyd
Copy link

itsjeyd commented Apr 1, 2025

Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Apr 10, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/grade-summary-tooltip branch from c8c8168 to da56709 Compare April 15, 2025 12:39
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/grade-summary-tooltip branch from ea41873 to 2f58666 Compare April 15, 2025 13:33
@vladislavkeblysh
Copy link
Author

@itsjeyd This PR ready to review

@itsjeyd
Copy link

itsjeyd commented Apr 24, 2025

@vladislavkeblysh Same question here.

@itsjeyd itsjeyd removed the inactive PR author has been unresponsive for several months label Apr 24, 2025
@PKulkoRaccoonGang
Copy link
Contributor

[inform]: Awaiting Product Review

@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 24, 2025
@vladislavkeblysh vladislavkeblysh marked this pull request as draft May 1, 2025 14:05
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang
Copy link
Contributor

Some context after accessibility review:

When activating the grade summary tooltip, keyboard focus is not placed in the tooltip content. There is no mechanism to close the tooltip using the keyboard.

Recommended actions:

  1. Programmatically place focus on tooltip content when the tooltip button is activated.
  2. Provide a mechanism to close the tooltip using the keyboard. The escape key is recommended.
  3. Ensure focus is trapped within the tooltip until it is close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKulkoRaccoonGang PKulkoRaccoonGang PKulkoRaccoonGang approved these changes

@jansenk jansenk Awaiting requested review from jansenk

@KristinAoki KristinAoki Awaiting requested review from KristinAoki

@ihor-romaniuk ihor-romaniuk Awaiting requested review from ihor-romaniuk

At least 1 approving review is required to merge this pull request.

Assignees

@vladislavkeblysh vladislavkeblysh

Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Contributions
Status: Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vladislavkeblysh @openedx-webhooks @itsjeyd @PKulkoRaccoonGang @open-craft-grove